Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ESP32 Partition table #1855

Merged
merged 1 commit into from
Mar 11, 2021
Merged

Fix ESP32 Partition table #1855

merged 1 commit into from
Mar 11, 2021

Conversation

AdrianSoundy
Copy link
Member

@AdrianSoundy AdrianSoundy commented Mar 11, 2021 •
edited
Loading

Description

Reduced Deployment partitions down to 3Mb for 8Mb and 16Mb partition tables

Partition sizes of over 4Mb seem to hang when mapping to memory address
Sizes of 3.5Mb to 4Mb seems to get a out of memory error.

Motivation and Context

How Has This Been Tested?

Tested with 8Mb flash board, 16Mb should be ok.

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Config and build (change in the configuration and build system, has no impact on code or features)
  • Dependencies (update dependencies and changes associated, has no impact on code or features)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@josesimoes josesimoes added the Series: ESP32 Everything related specifically with ESP32 series targets label Mar 11, 2021
josesimoes
josesimoes approved these changes Mar 11, 2021
View reviewed changes
Copy link
Member

@josesimoes josesimoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for fixing this.

@josesimoes josesimoes changed the title ESP32 Partition table update to stop boot loops Fix ESP32 Partition table Mar 11, 2021
@josesimoes josesimoes merged commit ec12537 into nanoframework:develop Mar 11, 2021
@AdrianSoundy AdrianSoundy deleted the esp32-partitions branch March 11, 2021 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josesimoes josesimoes josesimoes approved these changes

Assignees
No one assigned
Labels
Series: ESP32 Everything related specifically with ESP32 series targets Type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ESP32_WROOM firmware boot loop
3 participants
@AdrianSoundy @josesimoes @nfbot